65 Commits

Author SHA1 Message Date
Michael Smith
02817d9ec1 Merge branch 'main' into mes/mod-temp-valid 2025-04-18 19:02:54 +00:00
Michael Smith
a6c1e9c5ea
Merge pull request #8 from coder/mes/script-disable
fix: disable cron site check
2025-04-17 19:18:48 -04:00
Michael Smith
87468aadb8 fix: disable cron site check 2025-04-17 23:07:43 +00:00
Michael Smith
fd0c2698b9
Merge pull request #7 from coder/mes/extra-readmes
fix: add missing README files for registry directory
2025-04-17 15:21:00 -04:00
Michael Smith
c4696836b6 fix: add missing README files for registry directory 2025-04-17 19:17:13 +00:00
Michael Smith
385966dc90
Merge pull request #6 from coder/mes/script-fix
fix: update script path
2025-04-17 14:18:50 -04:00
Michael Smith
5829345413 fix: update script path 2025-04-17 18:02:01 +00:00
Michael Smith
9e9d84db1b
Merge pull request #5 from coder/mes/structure-fix
## Changes made
- Removed GCP deploy script (for now). Will be added back once we have things configured
- Moved the Apache Airflow under the NatainData user namespace (looked through the GitHub history for modules and saw that she was the creator)
2025-04-17 11:12:04 -04:00
Michael Smith
9356d8c67f fix: restructure modules repo to reflect current status 2025-04-17 15:06:01 +00:00
Michael Smith
376664ca04
chore: migrate all Coder modules to Registry repo (#4)
Addresses part of https://github.com/coder/internal/issues/532 (but doesn't fully close it out).

This is a huge PR, but chunking it up seemed pointless, since we're largely copying over existing files. I'm going to try commenting on the main areas I think are worth paying attention to

## Changes made
- Migrated over all Coder modules from coder/modules, and put them in their correct user namespaces.
- Added README.md files to all newly-created user namespaces
- Updated all image paths for every image used, to make sure they don't break (I switched the paths programmatically, and then manually verified every README to guarantee this).
- Added README.md files for each contributor who previously made a module
- Updated our `tsconfig.json` file to use modern libraries when run from the server, and made a custom `tsconfig.json` just for the `windows-rdp` module (which has more restrictive browser concerns)
- Added CI step to run all the module tests we currently have

## Notes
- There were a lot of Bash script files that weren't carried over in this PR, partly because I don't know Bash well enough to know (1) whether they're still needed, or (2) modify them to account for the new file structure. Those can be brought over later.
- We had a `lint.ts` file that provided some light validation of some of the modules. After going through it, there were so many bugs and issues with the code that I legitimately think that it barely provided a safety net at all. I got rid of it entirely, with the intention of adding the functionality that was originally intended to the current validation logic (to be handled in a separate PR).
- I changed how we set up the `.images` directory, because it felt like it would be chaos if a bunch of users try to throw all their images in one giant directory, with no guidelines on how to do it. I instead made it so that images should be scoped by namespace, which felt a lot more manageable. The `.icons` directory is still at the top level, because realistically, there are only going to be so many types of icons referenced, so it's fine for those to be shared.
- I don't think the `maintainer_github` and `contributor_github` fields make sense anymore, but those can be stripped out once we've updated the Registry site build step to use the new Registry repo
   - My gut instinct is to use the user namespace to determine the main owner of the module, and then add a `contributors` string list to indicate which other users have contributed meaningfully to it. We can then add validation to make sure that every value in that list exists as another namespace in the repo

## What still needs to be migrated (in separate PRs)
These are the main files of interest that still probably need to be copied over from the `/modules` repo:
- `new.sh`
- `terraform_validate.sh`
- `update-version.sh`

They're probably going to require enough changes that it's worth handling them in a separate PR.
2025-04-17 09:49:54 -04:00
Michael Smith
d2ebc2b1d9 fix: update icon URLs 2025-04-16 15:22:13 +00:00
Michael Smith
e6efd71fca wip: more progress 2025-04-16 04:02:45 +00:00
Michael Smith
f10f5a4403 chore: add sample data 2025-04-16 02:44:34 +00:00
Michael Smith
a00a9ce589 wip: commit progress 2025-04-16 02:17:15 +00:00
Michael Smith
6eef059e21 wip: commit progress on git manipulation 2025-04-16 01:58:36 +00:00
Michael Smith
135d5c8111 fix: remove potential race condition 2025-04-16 01:44:21 +00:00
Michael Smith
f23bbca2e7 refactor: start making main() leaner 2025-04-16 00:03:01 +00:00
Michael Smith
19226af067 wip: commit more progress 2025-04-15 23:56:48 +00:00
Michael Smith
e888506063 wip: get concurrency stubs set up 2025-04-15 18:10:32 +00:00
Michael Smith
aa0b8710d3 wip: commit progress on validation 2025-04-15 17:29:51 +00:00
Michael Smith
17c9667db6 wip: commit progress for module validation 2025-04-15 16:35:33 +00:00
Michael Smith
18680d0a15 chore: add directory validation in separate file 2025-04-15 16:02:33 +00:00
Michael Smith
94ca584b9e refactor: move where validation phase is defined 2025-04-15 15:12:03 +00:00
Michael Smith
6e5d960871 refactor: split README logic into separate file 2025-04-15 15:06:16 +00:00
Michael Smith
3fa316dc37 wip: get basic GH API call stuff working 2025-04-15 14:54:30 +00:00
Michael Smith
9f035798d1 wip: commit progress 2025-04-15 14:32:38 +00:00
Michael Smith
25d301c654 wip: commit progress 2025-04-14 20:40:25 +00:00
Michael Smith
d2c5f8d3bd fix: actually add the test calls 2025-04-14 18:27:10 +00:00
Michael Smith
0a597c23f4 test: try logging refs 2025-04-14 18:25:24 +00:00
Michael Smith
ec1b4a72cb test: see how CI output works 2025-04-14 18:13:22 +00:00
Michael Smith
860a633e11 wip: add support for reading env from CI 2025-04-14 18:09:43 +00:00
Michael Smith
a2abeaee2f fix: update script references for CI 2025-04-14 17:58:59 +00:00
Michael Smith
73f3ea23c0 refactor: move to cmd dir 2025-04-14 17:53:54 +00:00
Michael Smith
7fd409fa73
chore: add CI step for validating contributor READMEs
Closes https://github.com/coder/internal/issues/530

## Changes made
- Created top-level test directories for Coder and NataInData (a developer who contributed a module for us in the past)
- Created Go script for validating the structure of each README, while being as granular as possible with any errors for better feedback
- Added CI step for running the script

## Notes
- I did a good bit of manual testing, but I am planning to circle back with a follow-up PR to add proper tests for the script functionality. I might push that off until after the majority of the new Registry work is done, though
- Not 100% sold on the structure of the Go directories. That's likely to change as I add more code for validating the modules and templates
2025-04-14 13:47:05 -04:00
Michael Smith
50d651c2f9 fix: update CI step 2025-04-14 13:57:02 +00:00
Michael Smith
a2c246ea06 refactor: split out error func 2025-04-14 13:52:40 +00:00
Michael Smith
39b264a7f9 refactor: split up package boundaries 2025-04-14 13:48:19 +00:00
Michael Smith
bdf9c5f51b refactor: update namespacing 2025-04-14 13:45:41 +00:00
Michael Smith
ffd9861e03 refactor: extract pseudo-constants 2025-04-14 13:37:17 +00:00
Michael Smith
5c45642e4b refactor: split off another function 2025-04-11 17:26:45 +00:00
Michael Smith
96fa5d4157 refactor: apply majority of feedback 2025-04-11 16:55:09 +00:00
Michael Smith
65fb7bcffb refactor: standardize how errors are defined 2025-04-11 13:44:15 +00:00
Michael Smith
affc5063ca refactor: split validation function into smaller pieces 2025-04-10 21:01:58 +00:00
Michael Smith
abf9815a84 fix: update static files 2025-04-10 20:40:54 +00:00
Michael Smith
bc4bbdaa07 fix: remove unnecessary matrix 2025-04-09 19:25:48 +00:00
Michael Smith
3b9c01ea6c fix: ensure relative avatars keep small scope 2025-04-09 16:07:58 +00:00
Michael Smith
e035f1fca3 chore: beef up CI 2025-04-09 15:26:22 +00:00
Michael Smith
88f7be27ec chore: set up initial version of CI 2025-04-09 15:01:08 +00:00
Michael Smith
3b9ec5ec41 chore: finish initial version of validation script 2025-04-08 21:23:36 +00:00
Michael Smith
9e48eb806f refactor: reorganize scripts again 2025-04-08 21:01:36 +00:00