ab6799ac07
## Summary Fixes a race condition when multiple `git-clone` modules with `post_clone_script` run concurrently. ## Problem All instances of the git-clone module use the same hardcoded `/tmp/post_clone.sh` path. When multiple modules run concurrently (or overlap), they collide on the same temp file, causing: ``` rm: cannot remove '/tmp/post_clone.sh': No such file or directory ``` This results in a non-zero exit code, causing the workspace to appear unhealthy. ## Solution Use `mktemp` to generate a unique temporary filename for each module instance: ```bash POST_CLONE_TMP=$(mktemp /tmp/post_clone_XXXXXX.sh) ``` This ensures each concurrent execution uses its own temp file, eliminating the race condition. Fixes #600 --------- Co-authored-by: blink-so[bot] <211532188+blink-so[bot]@users.noreply.github.com> Co-authored-by: Matyas Danter <mdanter@gmail.com>
68 lines
1.7 KiB
Bash
68 lines
1.7 KiB
Bash
#!/usr/bin/env bash
|
|
|
|
REPO_URL="${REPO_URL}"
|
|
CLONE_PATH="${CLONE_PATH}"
|
|
BRANCH_NAME="${BRANCH_NAME}"
|
|
# Expand home if it's specified!
|
|
CLONE_PATH="$${CLONE_PATH/#\~/$${HOME}}"
|
|
DEPTH="${DEPTH}"
|
|
POST_CLONE_SCRIPT="${POST_CLONE_SCRIPT}"
|
|
|
|
# Check if the variable is empty...
|
|
if [ -z "$REPO_URL" ]; then
|
|
echo "No repository specified!"
|
|
exit 1
|
|
fi
|
|
|
|
# Check if the variable is empty...
|
|
if [ -z "$CLONE_PATH" ]; then
|
|
echo "No clone path specified!"
|
|
exit 1
|
|
fi
|
|
|
|
# Check if `git` is installed...
|
|
if ! command -v git > /dev/null; then
|
|
echo "Git is not installed!"
|
|
exit 1
|
|
fi
|
|
|
|
# Check if the directory for the cloning exists
|
|
# and if not, create it
|
|
if [ ! -d "$CLONE_PATH" ]; then
|
|
echo "Creating directory $CLONE_PATH..."
|
|
mkdir -p "$CLONE_PATH"
|
|
fi
|
|
|
|
# Check if the directory is empty
|
|
# and if it is, clone the repo, otherwise skip cloning
|
|
if [ -z "$(ls -A "$CLONE_PATH")" ]; then
|
|
if [ -z "$BRANCH_NAME" ]; then
|
|
echo "Cloning $REPO_URL to $CLONE_PATH..."
|
|
if [ "$DEPTH" -gt 0 ]; then
|
|
git clone --depth "$DEPTH" "$REPO_URL" "$CLONE_PATH"
|
|
else
|
|
git clone "$REPO_URL" "$CLONE_PATH"
|
|
fi
|
|
else
|
|
echo "Cloning $REPO_URL to $CLONE_PATH on branch $BRANCH_NAME..."
|
|
if [ "$DEPTH" -gt 0 ]; then
|
|
git clone --depth "$DEPTH" -b "$BRANCH_NAME" "$REPO_URL" "$CLONE_PATH"
|
|
else
|
|
git clone "$REPO_URL" -b "$BRANCH_NAME" "$CLONE_PATH"
|
|
fi
|
|
fi
|
|
else
|
|
echo "$CLONE_PATH already exists and isn't empty, skipping clone!"
|
|
fi
|
|
|
|
# Run post-clone script if provided
|
|
if [ -n "$POST_CLONE_SCRIPT" ]; then
|
|
echo "Running post-clone script..."
|
|
POST_CLONE_TMP=$(mktemp)
|
|
echo "$POST_CLONE_SCRIPT" | base64 -d > "$POST_CLONE_TMP"
|
|
chmod +x "$POST_CLONE_TMP"
|
|
cd "$CLONE_PATH" || exit
|
|
$POST_CLONE_TMP
|
|
rm "$POST_CLONE_TMP"
|
|
fi
|