refactor: start making main() leaner

cmd/readmevalidation/contributors.go

@@ -3,6 +3,7 @@ package main
 import (
 	"errors"
 	"fmt"
+	"log"
 	"net/url"
 	"os"
 	"path"
@@ -371,3 +372,25 @@ func validateContributorRelativeUrls(contributors map[string]contributorProfile)
 		errors: problems,
 	}
 }
+
+func validateAllContributors(errChan chan<- error) {
+	allReadmeFiles, err := aggregateContributorReadmeFiles()
+	if err != nil {
+		errChan <- err
+		return
+	}
+	log.Printf("Processing %d README files\n", len(allReadmeFiles))
+	contributors, err := parseContributorFiles(allReadmeFiles)
+	log.Printf("Processed %d README files as valid contributor profiles", len(contributors))
+	if err != nil {
+		errChan <- err
+		return
+	}
+	err = validateContributorRelativeUrls(contributors)
+	if err != nil {
+		errChan <- err
+		return
+	}
+	log.Println("All relative URLs for READMEs are valid")
+	log.Printf("Processed all READMEs in the %q directory\n", rootRegistryPath)
+}

cmd/readmevalidation/main.go

@@ -87,26 +87,7 @@ func main() {
 	wg.Add(1)
 	go func() {
 		defer wg.Done()
-
+		validateAllContributors(errChan)
-		allReadmeFiles, err := aggregateContributorReadmeFiles()
-		if err != nil {
-			errChan <- err
-			return
-		}
-		log.Printf("Processing %d README files\n", len(allReadmeFiles))
-		contributors, err := parseContributorFiles(allReadmeFiles)
-		log.Printf("Processed %d README files as valid contributor profiles", len(contributors))
-		if err != nil {
-			errChan <- err
-			return
-		}
-		err = validateContributorRelativeUrls(contributors)
-		if err != nil {
-			errChan <- err
-			return
-		}
-		log.Println("All relative URLs for READMEs are valid")
-		log.Printf("Processed all READMEs in the %q directory\n", rootRegistryPath)
 	}()
 
 	// Validate modules