yamanin/registry
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix JetBrains URL to include agent_id parameter

Browse Source 
- Updates URL generation logic to include the agent_id.
- Adjusts tests to validate the presence of agent_id in URLs.
This commit is contained in:
Muhammad Atif Ali 2025-07-07 16:15:43 +05:00
parent 05311159e1
commit b7cc89cdfd
No known key found for this signature in database
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
registry/coder/modules/jetbrains/main.test.ts
View File

@ -292,7 +292,7 @@ describe("jetbrains", async () => {
); );
const url = coder_app?.instances[0].attributes.url; const url = coder_app?.instances[0].attributes.url;
expect(url).toContain("jetbrains://gateway/com.coder.toolbox"); expect(url).toContain("jetbrains://gateway/coder");
expect(url).toContain("&workspace="); expect(url).toContain("&workspace=");
expect(url).toContain("&owner="); expect(url).toContain("&owner=");
expect(url).toContain("&folder=/custom/project/path"); expect(url).toContain("&folder=/custom/project/path");
@ -300,6 +300,7 @@ describe("jetbrains", async () => {
expect(url).toContain("&token=$SESSION_TOKEN"); expect(url).toContain("&token=$SESSION_TOKEN");
expect(url).toContain("&ide_product_code=GO"); expect(url).toContain("&ide_product_code=GO");
expect(url).toContain("&ide_build_number="); expect(url).toContain("&ide_build_number=");
expect(url).toContain("&agent_id=test-agent-123");
}); });
it("should include build numbers from API in URLs", async () => { it("should include build numbers from API in URLs", async () => {
@ -993,7 +994,7 @@ describe("jetbrains", async () => {
for (const app of coder_apps) { for (const app of coder_apps) {
// Should have valid URLs with build numbers // Should have valid URLs with build numbers
expect(app.instances[0].attributes.url).toContain( expect(app.instances[0].attributes.url).toContain(
"jetbrains://gateway/com.coder.toolbox", "jetbrains://gateway/coder",
); );
expect(app.instances[0].attributes.url).toContain("ide_build_number="); expect(app.instances[0].attributes.url).toContain("ide_build_number=");
expect(app.instances[0].attributes.url).toContain("ide_product_code="); expect(app.instances[0].attributes.url).toContain("ide_product_code=");

4
registry/coder/modules/jetbrains/main.tf
View File

@ -238,6 +238,8 @@ resource "coder_app" "jetbrains" {
"&ide_product_code=", "&ide_product_code=",
each.key, each.key,
"&ide_build_number=", "&ide_build_number=",
local.options_metadata[each.key].build local.options_metadata[each.key].build,
"&agent_id=",
var.agent_id,
]) ])
} }