From 7979582e3c082c72503977f57a0a0d4c3cb32a44 Mon Sep 17 00:00:00 2001
From: "blink-so[bot]" <211532188+blink-so[bot]@users.noreply.github.com>
Date: Wed, 20 Aug 2025 17:33:42 +0000
Subject: [PATCH] Address review feedback

- Remove testing comment as requested
- Update healthcheck URL to handle both subdomain true/false cases
- Match the same URL pattern as the main app URL
---
 registry/coder/modules/jupyterlab/main.tf | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/registry/coder/modules/jupyterlab/main.tf b/registry/coder/modules/jupyterlab/main.tf
index 47fce254..701bcd0f 100644
--- a/registry/coder/modules/jupyterlab/main.tf
+++ b/registry/coder/modules/jupyterlab/main.tf
@@ -80,11 +80,8 @@ resource "coder_app" "jupyterlab" {
   order        = var.order
   group        = var.group
 
-  # Healthcheck ensures JupyterLab is fully ready before showing as available
-  # Test with: git clone https://github.com/coder/registry.git && cd registry/registry/coder/modules/jupyterlab
-  # Then use this module in a template to verify the app only appears when JupyterLab is responding
   healthcheck {
-    url       = "http://localhost:${var.port}/api/status"
+    url       = var.subdomain ? "http://localhost:${var.port}/api/status" : "http://localhost:${var.port}/@${data.coder_workspace_owner.me.name}/${data.coder_workspace.me.name}/apps/jupyterlab/api/status"
     interval  = 5
     threshold = 6
   }