From 6b9d0d48039d4cc5925b1bade5b40496812407a3 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Sun, 6 Jul 2025 16:42:33 +0500 Subject: [PATCH] chore: update RDP modules display names, icon and docs (#175) --- .icons/rdp.svg | 35 ++++++++++++++++ MAINTAINER.md | 10 ++--- bun.lockb | Bin 10569 -> 9848 bytes package.json | 14 +++---- .../coder/modules/local-windows-rdp/README.md | 15 +++---- .../modules/local-windows-rdp/main.test.ts | 4 +- .../coder/modules/local-windows-rdp/main.tf | 5 +-- registry/coder/modules/windows-rdp/README.md | 38 +++++++----------- .../coder/modules/windows-rdp/main.test.ts | 5 --- registry/coder/modules/windows-rdp/main.tf | 15 +++---- .../templates/digitalocean-linux/README.md | 3 -- .../templates/gcp-devcontainer/README.md | 1 - registry/coder/templates/gcp-linux/README.md | 1 - .../templates/gcp-vm-container/README.md | 1 - .../coder/templates/gcp-windows/README.md | 1 - registry/coder/templates/incus/README.md | 1 - 16 files changed, 77 insertions(+), 72 deletions(-) create mode 100644 .icons/rdp.svg diff --git a/.icons/rdp.svg b/.icons/rdp.svg new file mode 100644 index 00000000..a6722326 --- /dev/null +++ b/.icons/rdp.svg @@ -0,0 +1,35 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/MAINTAINER.md b/MAINTAINER.md index 69d1a657..2011b5aa 100644 --- a/MAINTAINER.md +++ b/MAINTAINER.md @@ -14,9 +14,7 @@ brew install go sudo apt install golang-go ``` -## Daily Tasks - -### Review PRs +## Reviewing a PR Check that PRs have: @@ -26,7 +24,7 @@ Check that PRs have: - [ ] Formatted code (`bun run fmt`) - [ ] Avatar image for new namespaces (`avatar.png` or `avatar.svg` in `.images/`) -#### Version Guidelines +### Version Guidelines When reviewing PRs, ensure the version change follows semantic versioning: @@ -42,7 +40,7 @@ PRs should clearly indicate the version change (e.g., `v1.2.3 → v1.2.4`). go build ./cmd/readmevalidation && ./readmevalidation ``` -## Releases +## Making a Release ### Create Release Tags @@ -99,5 +97,3 @@ status: "community" # or "partner", "official" - **Tests fail**: Ensure Docker with `--network=host`, check Terraform syntax - **Wrong file structure**: Use `./scripts/new_module.sh` for new modules - **Missing namespace avatar**: Must be `avatar.png` or `avatar.svg` in `.images/` directory - -That's it. Keep it simple. diff --git a/bun.lockb b/bun.lockb index 7f379c9d1d11dde5144bad2cac47850647568d60..2fde7ba24d0278805ff57d066d28f3a9c014140c 100755 GIT binary patch delta 2425 zcmZWr2~g8l8h`&BkZ>gd0|{5aa29icfpAC=1#D3(P|7MtjS>(s1d>QOWPz%6TV;ek ztQK(<)?$mLg47+5mcxn_JPJB>T#<_PSSk+7N`cZM-R}>H%S_+QoAnoT9~ti?$W{osmTlMT4TZUCR1F7Y zphU9;pbV6e1>Qh}GU~0YU#yFJU5SqoTYVh4o}6-F!u8;3gOz0=uBwu3sqnh6DwwGa zyYeiqrla4?_nTO0`7hXqQcKuk8O0ChQW(rwC`$p}skodP#Mui{2uKhDL0H59J#U;# zXIcT^4*(PihXfUj8B8`DMjExDN@TXE4PL`RPYwth_t1g}JuajviSKbcO-XkE#kKew zS|~FMc7dQ{hRZ?cBrc>YDHBwDkseM&;90tod78GUK*QzqAmSb_G*dENAgeGiB1j|7 zW{^Tj34)WEk!3-;6b9!kAY>tSa7v=aLI8OJ2pN`4m_(>18^Q_CnkxwvZZ}tQ>fy3U ztv`9DJT}7@8AUjZxs^azV?}0NnQtP+$vMzT_y{XZ52i(g$%lCTMTju+s_36(M zM+Xx^zL@5BPbQR63nJU`OG{p<=hTkgd3rA;xbZkEXZ6F3!)Hbx{6$*h)Su?Viz2iy zr|Qf+%N37P(Oej>rbJY&*(qxZ_$m|kZQ@=IBQ9hv$quga)u5fK%9$x2(EfBJ|8aFh z=fvMXX*@A|uz5sT%P7*;ncqhHPBkfy%^c+?oC)ea^~0pzBjn-tYm4Jk>Z@mN5!oxd zhH#S=uXICauG_Vq(%EZ8D+k6l`}uvTm~*!>pYi>mo}N}$_UV5cL-U&RT%OfdP;;{A zZ~5kjy8BMFUwbFdqrKnq_E@t0lI+Z1<%SSV7I`Q|@tigD`B$!2lwms_Ie3f2pZ%k2 z(ABqEnn#W1`kb2c3L03;KiyZ1)_l;F|MYxC(F}2Qh)$n+%T4n2gJU?=nul*##}Z7; zw@Jc08*5x*6H8d)K9H`0Bx1!9*0_+BgbP^Kco-xW_GKqwAGS5FV8;?1{4bF1vaL&R zAKthB%MHqZ8mM>NtgNnM{9R1iCv6wDOy*BNTRl75zx(qeZ4PxA#M;cVjaTLKBA>BK zcIUL)CN5vvtG+W>pS+|-^7}Ro8WjoFsB4}yw@huHJMqzU+m*NLe(d|ti};3=O($y;c zWyM|1SzDI)Sc9W>g~EB+c>KRDs*k_v71Z}co_O=g$m!V|;Vb?SwmAQFQ1|Z4y@4sv}b8tFqLpV(*45MdGa}!4A5FanHlP>$u=j-kGrk^<1%m+C8aE z3)jDleQ@M_?f7@jC7x`D_xIH1@n)Rd4(-Onwmkf)-9aK0%a+BkO-)z^zk0H{Vi~sp ze)lw{smuCfcWy`P1b3KbTfkquphL#hA`C}4$sOnaSR5qCgV|<;d5*Z#DbkZXa)1fm z$+nJIFrm$pEt+iCh}3q(?#@mY>l|SVqm4B5;+hO?;fMi~{0gafzq25kbOVii!JKph zU4B6(Ly)e?5Wp~q3zK|Tk`e4-lAcD5LAqV=wDW7&!-b9DGUBBX4P+w<)pF{oPf#? zF7gZ$^_lpFLZSg;=#M6n{C)S}M<3_cys?1D#Xu;zI<>)&rPkd~lg6L-Yp-AvX<#9i zB4i@e=##^Z^$s1sf{njeA(r7>*FYx|i(YB2tQ>lOoB^PWOckLn+~dk8lJSsh0Ob)C zvjyu3JDe)u6V+Jc#+Msuv&=+;5Kk5iRUu^JQ4=wO%K&f*RVU&H0*N2o6=J(CsG>^a zY7wSaYx31Paa4gpt;yRH@Y4fe)0F1qAwz$4%*Y*GS;|6!Pmtfz5okG1!P_tD}1a!Gr4-8#0R` z;O5l1dP%x=d$wAap)p|9@;9jPOgPWO4c}buK!pp2y#SjF*@Obe3EhQ%vXO}XZ!cPS zEPPP7iU`CS4`J(b;XH*#ek6F@%bu=NtF{~PpwP)Fg8aXsmn&8@p8vQ-U6)m)?#NL8w$8p`#k<1X%FNH delta 2781 zcmZ`*30PA}5`OO`AqkQb#DoMxATR+XBm@LR1RPfsJU~$tH7F7l6=V}G(OF6B|TejMUGqs@8Du++-7=|h<*9rd+p!rEkI2@1+jR+g(C zuOtbAOArN_<^`$A0H$T9%uM$+&&@CyGc!|-rnH%+`NkB2a0RRn=vgR&5CXjlln-=% zYI=(A!r8KO3~;s|M7rMg`;y?XFATFWNTmdTNEv#R^QMWCf8Qkkl@m z8w&9qVl@GiL^;5PVh$F^y&t{2=o}ycfN($xL&E-dRkl|<}JDe;) zQ`q66<8Xd>W7sO}f#6!TN*P=s063KY3qUNWKsIvWA9DRNPgPRJp&fq8orz3 z;Z>7eDwY>&j$F=(S)MgX`Hwo;>a#vW=be~4f8Up^n(R9TBi0yhsyEh0QpGJkZ;Nca zW7DnyWv-n6bpVgwTGAAHa`F0)mdMi0clDQfQ`!?oHGEp7ToH6T)qk6|MI>!^co)Df zy4uye&*1f}`&++3S08sJ_qSv_qAd=R(fhN!+TXOO6MdXI1@p61OMf)tnXr&lBqRV|;wc;9uEtk~sLG33C2gQm*ov&Oos=J?hnZ*R8oj*Ip?B%sMW9^&z0 z$UbNaF9C7*JX8-H4{`Yk=ooNm{1{SzYJr<8;2~E*3@JjXf&?TH^3Y{L%os=8Jzi^? z$X>r>cG42J#-&Aa^NdK-fa({k{?#wPJHn!9KD4q$mbD>x;ts{3kz;P{e7%Nq@k86a z#FeLrM{ULW;>L(ZR4x+bxuWv?)a@Mc(xUvZlZ%;>2bJ$^w%FI!IZ4;npx7U$Ijn#B>Ibr0 zuB}1uJ8qj&l*Xx}onK#x`lfu%@gmuiy;5Y%${F#rX7sYpn`I`azI(78D``>CDd(ObDrTU+lGHqAOWt~`lh;$0YjD)Hw0&m-?w@%+ZD%y2MEu14 z-TQ6(D!5_?`-2|N=>ZKf2ZnnZwk-bDcz80~X;g7Nb>zw9?C8+UFAq=ubES=87vwG8 zK>DCl;wV=-J^28R(-D3~=u|Zhi5ypwv1p599de_bj!t&6Fwswr$Ndw{8?f%l!uu4DZVA$GidAy1Q3!q_&bsqE@8!kuX(qSw-Re~&187V`br82P` zcpQ-oJb?BJtGV}efg!el?;9jW0zbrTG~GopUH~JUFYx1wvkXpOn1^Ibh@iu62{ClM z5PqcbrEu=;cp)sqm>Ygwp^b1ur(JxkUgM0s&9h+OfaS(yA!!KI1Zo1-%A|65@9`|0 zpy|xXAq_f>PUEjffik}ke~nh-PtY-^Q!?o2HSi+{TvmWj1tA}!!alkbx&xxs==2&L z+9C^#rb`MsrBhZE6bQQb_>|SWwmf@Nv=s>e;16qoyLycl$>mbUAfUnWLF84mP%f3x z^++=B!n6}#|LGW*(1EvFf>?xh$@LV;L@n~s5S%#nI^N5Xc{*3_@}6;KdpyMk1u&+N!5SO#K!H}4Lm-} z$C=-z3R6biJB%Xxhr4*g`;2RWG=ruqIa1}_0diJBSaIzJB!37eWGmtLk9|2Wi~+3^;n!?iR+f-VTf$ z9jol7nATept8ylDkejC*edEdI=a|7%j@h>-d{!eMMxRwehE5ZNM4o0COVDnW4AlFQ PAy$n5l?#m4dA9xr)&MsQ diff --git a/package.json b/package.json index 733230db..1f34a2d2 100644 --- a/package.json +++ b/package.json @@ -8,16 +8,16 @@ "update-version": "./update-version.sh" }, "devDependencies": { - "@types/bun": "^1.2.9", - "bun-types": "^1.1.23", + "@types/bun": "^1.2.18", + "bun-types": "^1.2.18", "gray-matter": "^4.0.3", - "marked": "^12.0.2", - "prettier": "^3.3.3", - "prettier-plugin-sh": "^0.13.1", + "marked": "^16.0.0", + "prettier": "^3.6.2", + "prettier-plugin-sh": "^0.18.0", "prettier-plugin-terraform-formatter": "^1.2.1" }, "peerDependencies": { - "typescript": "^5.5.4" + "typescript": "^5.8.3" }, "prettier": { "plugins": [ @@ -25,4 +25,4 @@ "prettier-plugin-terraform-formatter" ] } -} \ No newline at end of file +} diff --git a/registry/coder/modules/local-windows-rdp/README.md b/registry/coder/modules/local-windows-rdp/README.md index 4b447967..4ff726a1 100644 --- a/registry/coder/modules/local-windows-rdp/README.md +++ b/registry/coder/modules/local-windows-rdp/README.md @@ -1,24 +1,25 @@ --- -display_name: Windows RDP Desktop +display_name: RDP Desktop description: Enable RDP on Windows and add a one-click Coder Desktop button for seamless access -icon: ../../../../.icons/desktop.svg +icon: ../../../../.icons/rdp.svg maintainer_github: coder verified: true supported_os: [windows] -tags: [rdp, windows, desktop, remote] +tags: [rdp, windows, desktop, local] --- # Windows RDP Desktop This module enables Remote Desktop Protocol (RDP) on Windows workspaces and adds a one-click button to launch RDP sessions directly through [Coder Desktop](https://coder.com/docs/user-guides/desktop). It provides a complete, standalone solution for RDP access, eliminating the need for manual configuration or port forwarding through the Coder CLI. -> **Note**: [Coder Desktop](https://coder.com/docs/user-guides/desktop) is required on client devices to use the Local Windows RDP access feature. +> [!NOTE] +> [Coder Desktop](https://coder.com/docs/user-guides/desktop) is required on client devices to use the Local Windows RDP access feature. ```tf module "rdp_desktop" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/local-windows-rdp/coder" - version = "1.0.0" + version = "1.0.1" agent_id = coder_agent.main.id agent_name = coder_agent.main.name } @@ -51,7 +52,7 @@ Uses default credentials (Username: `Administrator`, Password: `coderRDP!`): module "rdp_desktop" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/local-windows-rdp/coder" - version = "1.0.0" + version = "1.0.1" agent_id = coder_agent.main.id agent_name = coder_agent.main.name } @@ -65,7 +66,7 @@ Specify a custom display name for the `coder_app` button: module "rdp_desktop" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/local-windows-rdp/coder" - version = "1.0.0" + version = "1.0.1" agent_id = coder_agent.windows.id agent_name = "windows" display_name = "Windows Desktop" diff --git a/registry/coder/modules/local-windows-rdp/main.test.ts b/registry/coder/modules/local-windows-rdp/main.test.ts index 75b6dde0..9799b481 100644 --- a/registry/coder/modules/local-windows-rdp/main.test.ts +++ b/registry/coder/modules/local-windows-rdp/main.test.ts @@ -73,7 +73,7 @@ describe("local-windows-rdp", async () => { expect(app).not.toBeNull(); expect(app?.slug).toBe("rdp-desktop"); expect(app?.display_name).toBe("RDP Desktop"); - expect(app?.icon).toBe("/icon/desktop.svg"); + expect(app?.icon).toBe("/icon/rdp.svg"); expect(app?.external).toBe(true); // Verify the URI format @@ -95,7 +95,7 @@ describe("local-windows-rdp", async () => { // Verify the script was created expect(script).not.toBeNull(); expect(script?.display_name).toBe("Configure RDP"); - expect(script?.icon).toBe("/icon/desktop.svg"); + expect(script?.icon).toBe("/icon/rdp.svg"); expect(script?.run_on_start).toBe(true); expect(script?.run_on_stop).toBe(false); diff --git a/registry/coder/modules/local-windows-rdp/main.tf b/registry/coder/modules/local-windows-rdp/main.tf index b5f59445..0999c1ff 100644 --- a/registry/coder/modules/local-windows-rdp/main.tf +++ b/registry/coder/modules/local-windows-rdp/main.tf @@ -60,7 +60,7 @@ data "coder_workspace" "me" {} resource "coder_script" "rdp_setup" { agent_id = var.agent_id display_name = "Configure RDP" - icon = "/icon/desktop.svg" + icon = "/icon/rdp.svg" script = templatefile("${path.module}/configure-rdp.ps1", { username = var.username password = var.password @@ -73,9 +73,8 @@ resource "coder_app" "rdp_desktop" { slug = "rdp-desktop" display_name = var.display_name url = "coder://${local.server_name}/v0/open/ws/${data.coder_workspace.me.name}/agent/${var.agent_name}/rdp?username=${var.username}&password=${var.password}" - icon = "/icon/desktop.svg" + icon = "/icon/rdp.svg" external = true order = var.order group = var.group } - diff --git a/registry/coder/modules/windows-rdp/README.md b/registry/coder/modules/windows-rdp/README.md index 0899a79a..86248692 100644 --- a/registry/coder/modules/windows-rdp/README.md +++ b/registry/coder/modules/windows-rdp/README.md @@ -1,5 +1,5 @@ --- -display_name: Windows RDP +display_name: RDP Web description: RDP Server and Web Client, powered by Devolutions Gateway icon: ../../../../.icons/desktop.svg maintainer_github: coder @@ -14,11 +14,10 @@ Enable Remote Desktop + a web based client on Windows workspaces, powered by [de ```tf # AWS example. See below for examples of using this module with other providers module "windows_rdp" { - count = data.coder_workspace.me.start_count - source = "registry.coder.com/coder/windows-rdp/coder" - version = "1.2.1" - agent_id = resource.coder_agent.main.id - resource_id = resource.aws_instance.dev.id + count = data.coder_workspace.me.start_count + source = "registry.coder.com/coder/windows-rdp/coder" + version = "1.2.2" + agent_id = resource.coder_agent.main.id } ``` @@ -32,11 +31,10 @@ module "windows_rdp" { ```tf module "windows_rdp" { - count = data.coder_workspace.me.start_count - source = "registry.coder.com/coder/windows-rdp/coder" - version = "1.2.1" - agent_id = resource.coder_agent.main.id - resource_id = resource.aws_instance.dev.id + count = data.coder_workspace.me.start_count + source = "registry.coder.com/coder/windows-rdp/coder" + version = "1.2.2" + agent_id = resource.coder_agent.main.id } ``` @@ -44,11 +42,10 @@ module "windows_rdp" { ```tf module "windows_rdp" { - count = data.coder_workspace.me.start_count - source = "registry.coder.com/coder/windows-rdp/coder" - version = "1.2.1" - agent_id = resource.coder_agent.main.id - resource_id = resource.google_compute_instance.dev[0].id + count = data.coder_workspace.me.start_count + source = "registry.coder.com/coder/windows-rdp/coder" + version = "1.2.2" + agent_id = resource.coder_agent.main.id } ``` @@ -58,13 +55,8 @@ module "windows_rdp" { module "windows_rdp" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/windows-rdp/coder" - version = "1.2.1" + version = "1.2.2" agent_id = resource.coder_agent.main.id - resource_id = resource.aws_instance.dev.id - devolutions_gateway_version = "2025.1.6" # Specify a specific version + devolutions_gateway_version = "2025.2.2" # Specify a specific version } ``` - -## Roadmap - -- [ ] Test on Microsoft Azure. diff --git a/registry/coder/modules/windows-rdp/main.test.ts b/registry/coder/modules/windows-rdp/main.test.ts index 01a7e46d..125b3b3b 100644 --- a/registry/coder/modules/windows-rdp/main.test.ts +++ b/registry/coder/modules/windows-rdp/main.test.ts @@ -8,7 +8,6 @@ import { type TestVariables = Readonly<{ agent_id: string; - resource_id: string; share?: string; admin_username?: string; admin_password?: string; @@ -45,13 +44,11 @@ describe("Web RDP", async () => { await runTerraformInit(import.meta.dir); testRequiredVariables(import.meta.dir, { agent_id: "foo", - resource_id: "bar", }); it("Has the PowerShell script install Devolutions Gateway", async () => { const state = await runTerraformApply(import.meta.dir, { agent_id: "foo", - resource_id: "bar", }); const lines = findWindowsRdpScript(state) @@ -96,7 +93,6 @@ describe("Web RDP", async () => { import.meta.dir, { agent_id: "foo", - resource_id: "bar", }, ); @@ -116,7 +112,6 @@ describe("Web RDP", async () => { import.meta.dir, { agent_id: "foo", - resource_id: "bar", admin_username: customAdminUsername, admin_password: customAdminPassword, }, diff --git a/registry/coder/modules/windows-rdp/main.tf b/registry/coder/modules/windows-rdp/main.tf index b610c52c..c1b996dd 100644 --- a/registry/coder/modules/windows-rdp/main.tf +++ b/registry/coder/modules/windows-rdp/main.tf @@ -4,7 +4,7 @@ terraform { required_providers { coder = { source = "coder/coder" - version = ">= 0.17" + version = ">= 2.5" } } } @@ -35,11 +35,6 @@ variable "agent_id" { description = "The ID of a Coder agent." } -variable "resource_id" { - type = string - description = "The ID of the primary Coder resource (e.g. VM)." -} - variable "admin_username" { type = string default = "Administrator" @@ -53,14 +48,14 @@ variable "admin_password" { variable "devolutions_gateway_version" { type = string - default = "2025.2.1" + default = "2025.2.2" description = "Version of Devolutions Gateway to install. Defaults to the latest available version." } resource "coder_script" "windows-rdp" { agent_id = var.agent_id display_name = "windows-rdp" - icon = "/icon/desktop.svg" + icon = "/icon/rdp.svg" script = templatefile("${path.module}/powershell-installation-script.tftpl", { admin_username = var.admin_username @@ -101,7 +96,7 @@ resource "coder_app" "rdp-docs" { agent_id = var.agent_id display_name = "Local RDP Docs" slug = "rdp-docs" - icon = "https://raw.githubusercontent.com/matifali/logos/main/windows.svg" - url = "https://coder.com/docs/ides/remote-desktops#rdp-desktop" + icon = "/icon/windows.svg" + url = "https://coder.com/docs/user-guides/workspace-access/remote-desktops#rdp" external = true } diff --git a/registry/coder/templates/digitalocean-linux/README.md b/registry/coder/templates/digitalocean-linux/README.md index 5e72b0bf..b92c29c4 100644 --- a/registry/coder/templates/digitalocean-linux/README.md +++ b/registry/coder/templates/digitalocean-linux/README.md @@ -20,16 +20,13 @@ To deploy workspaces as DigitalOcean Droplets, you'll need: - DigitalOcean [personal access token (PAT)](https://docs.digitalocean.com/reference/api/create-personal-access-token) - DigitalOcean project ID (you can get your project information via the `doctl` CLI by running `doctl projects list`) - - Remove the following sections from the `main.tf` file if you don't want to associate your workspaces with a project: - - `variable "project_uuid"` - `resource "digitalocean_project_resources" "project"` - **Optional:** DigitalOcean SSH key ID (obtain via the `doctl` CLI by running `doctl compute ssh-key list`) - - Note that this is only required for Fedora images to work. ### Authentication diff --git a/registry/coder/templates/gcp-devcontainer/README.md b/registry/coder/templates/gcp-devcontainer/README.md index 0be4a786..134640a1 100644 --- a/registry/coder/templates/gcp-devcontainer/README.md +++ b/registry/coder/templates/gcp-devcontainer/README.md @@ -34,7 +34,6 @@ a service account: 1. Click **Create and continue**, and choose the following IAM roles to grant to the service account: - - Compute Admin - Service Account User diff --git a/registry/coder/templates/gcp-linux/README.md b/registry/coder/templates/gcp-linux/README.md index 60191040..daeda00b 100644 --- a/registry/coder/templates/gcp-linux/README.md +++ b/registry/coder/templates/gcp-linux/README.md @@ -32,7 +32,6 @@ a service account: 1. Click **Create and continue**, and choose the following IAM roles to grant to the service account: - - Compute Admin - Service Account User diff --git a/registry/coder/templates/gcp-vm-container/README.md b/registry/coder/templates/gcp-vm-container/README.md index 83704ee2..d8e9c10e 100644 --- a/registry/coder/templates/gcp-vm-container/README.md +++ b/registry/coder/templates/gcp-vm-container/README.md @@ -32,7 +32,6 @@ a service account: 1. Click **Create and continue**, and choose the following IAM roles to grant to the service account: - - Compute Admin - Service Account User diff --git a/registry/coder/templates/gcp-windows/README.md b/registry/coder/templates/gcp-windows/README.md index ac717e41..933f2d6f 100644 --- a/registry/coder/templates/gcp-windows/README.md +++ b/registry/coder/templates/gcp-windows/README.md @@ -32,7 +32,6 @@ a service account: 1. Click **Create and continue**, and choose the following IAM roles to grant to the service account: - - Compute Admin - Service Account User diff --git a/registry/coder/templates/incus/README.md b/registry/coder/templates/incus/README.md index def594cd..2a6d54e0 100644 --- a/registry/coder/templates/incus/README.md +++ b/registry/coder/templates/incus/README.md @@ -15,7 +15,6 @@ Develop in an Incus System Container and run nested Docker containers using Incu 1. Install [Incus](https://linuxcontainers.org/incus/) on the same machine as Coder. 2. Allow Coder to access the Incus socket. - - If you're running Coder as system service, run `sudo usermod -aG incus-admin coder` and restart the Coder service. - If you're running Coder as a Docker Compose service, get the group ID of the `incus-admin` group by running `getent group incus-admin` and add the following to your `compose.yaml` file: