yamanin/registry
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(filebrowser): use updated flag for baseURL (#626)

Browse Source 
## Description

This PR makes the following change to `coder/modules/filebrowser`:

- Use the updated `baseURL` flag instead of the deprecated flag
`baseurl`

Currently upstream [deprecates the `baseurl`
flag](https://github.com/filebrowser/filebrowser/blob/v2.53.0/cmd/root.go#L35-L51)
and prints this into the logs:

```
DEPRECATION NOTICE: Flag --baseurl has been deprecated, use --baseURL instead
```

Also, the upstream sets to [remove the support of the fallback after
July
2026](https://github.com/filebrowser/filebrowser/blob/v2.53.0/cmd/root.go#L56).
Without the fix, it might stop working afterwards.

## Type of Change

- [ ] New module
- [ ] New template
- [X] Bug fix
- [ ] Feature/enhancement
- [ ] Documentation
- [ ] Other

## Module Information

<!-- Delete this section if not applicable -->

**Path:** `registry/coder/modules/filebrowser`  
**New version:** `v1.1.4`  
**Breaking change:** [ ] Yes [X] No

## Testing & Validation

- [X] Tests pass (`bun test`)
- [X] Code formatted (`bun fmt`)
- [X] Changes tested locally

## Related Issues

None
This commit is contained in:
netsgnut 2025-12-31 03:29:48 -08:00 committed by GitHub
parent 678c3e631e
commit 2458a2bfa4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
registry/coder/modules/filebrowser/README.md
View File

@ -14,7 +14,7 @@ A file browser for your workspace.
module "filebrowser" { module "filebrowser" {
count = data.coder_workspace.me.start_count count = data.coder_workspace.me.start_count
source = "registry.coder.com/coder/filebrowser/coder" source = "registry.coder.com/coder/filebrowser/coder"
version = "1.1.3" version = "1.1.4"
agent_id = coder_agent.main.id agent_id = coder_agent.main.id
} }
``` ```
@ -29,7 +29,7 @@ module "filebrowser" {
module "filebrowser" { module "filebrowser" {
count = data.coder_workspace.me.start_count count = data.coder_workspace.me.start_count
source = "registry.coder.com/coder/filebrowser/coder" source = "registry.coder.com/coder/filebrowser/coder"
version = "1.1.3" version = "1.1.4"
agent_id = coder_agent.main.id agent_id = coder_agent.main.id
folder = "/home/coder/project" folder = "/home/coder/project"
} }
@ -41,7 +41,7 @@ module "filebrowser" {
module "filebrowser" { module "filebrowser" {
count = data.coder_workspace.me.start_count count = data.coder_workspace.me.start_count
source = "registry.coder.com/coder/filebrowser/coder" source = "registry.coder.com/coder/filebrowser/coder"
version = "1.1.3" version = "1.1.4"
agent_id = coder_agent.main.id agent_id = coder_agent.main.id
database_path = ".config/filebrowser.db" database_path = ".config/filebrowser.db"
} }
@ -53,7 +53,7 @@ module "filebrowser" {
module "filebrowser" { module "filebrowser" {
count = data.coder_workspace.me.start_count count = data.coder_workspace.me.start_count
source = "registry.coder.com/coder/filebrowser/coder" source = "registry.coder.com/coder/filebrowser/coder"
version = "1.1.3" version = "1.1.4"
agent_id = coder_agent.main.id agent_id = coder_agent.main.id
agent_name = "main" agent_name = "main"
subdomain = false subdomain = false

2
registry/coder/modules/filebrowser/run.sh
View File

@ -28,7 +28,7 @@ if [[ ! -f "${DB_PATH}" ]]; then
filebrowser users add admin "coderPASSWORD" --perm.admin=true --viewMode=mosaic 2>&1 | tee -a ${LOG_PATH} filebrowser users add admin "coderPASSWORD" --perm.admin=true --viewMode=mosaic 2>&1 | tee -a ${LOG_PATH}
fi fi
filebrowser config set --baseurl=${SERVER_BASE_PATH} --port=${PORT} --auth.method=noauth --root=$ROOT_DIR 2>&1 | tee -a ${LOG_PATH} filebrowser config set --baseURL=${SERVER_BASE_PATH} --port=${PORT} --auth.method=noauth --root=$ROOT_DIR 2>&1 | tee -a ${LOG_PATH}
printf "👷 Starting filebrowser in background... \n\n" printf "👷 Starting filebrowser in background... \n\n"